Changes per Ira's code review

paranext · Sep 3, 2024 · bf47710 · bf47710
1 parent eeff67e
commit bf47710
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/extensions/src/hello-world/src/web-views/hello-world.web-view.tsx b/extensions/src/hello-world/src/web-views/hello-world.web-view.tsx
@@ -208,7 +208,7 @@ globalThis.webViewComponent = function HelloWorld({
     'platform.selectMultipleProjects',
     useMemo(
       () => ({
-        prompt: `${localizedSelectProjectsPrompt}`,
+        prompt: localizedSelectProjectsPrompt,
         iconUrl: 'papi-extension://helloWorld/assets/offline.svg',
         title: localizedSelectProjectsTitle,
         selectedProjectIds: projects,

diff --git a/extensions/src/platform-scripture-editor/src/main.ts b/extensions/src/platform-scripture-editor/src/main.ts
@@ -130,7 +130,7 @@ const scriptureEditorWebViewProvider: IWebViewProvider = {
           await papi.projectDataProviders.get('platform.base', projectId)
         ).getSetting('platform.name')) ?? projectId
       }${isReadOnly ? '' : ` ${localizedEditable}`}`;
-    } else title = isReadOnly ? `${localizedResourceViewer}` : `${localizedScriptureEditor}`;
+    } else title = isReadOnly ? localizedResourceViewer : localizedScriptureEditor;
 
     return {
       title,

diff --git a/src/renderer/components/web-view.component.tsx b/src/renderer/components/web-view.component.tsx
@@ -38,9 +38,7 @@ export default function WebView({
   const [localizedStrings] = useLocalizedStrings(
     title && isLocalizeKey(title) ? [title] : [webViewKey],
   );
-  const defaultTitle = !title
-    ? title
-    : `${webViewType || contentType} ${localizedStrings[webViewKey]}`;
+  const defaultTitle = title || `${webViewType || contentType} ${localizedStrings[webViewKey]}`;
   const localizedTitle = title && isLocalizeKey(title) ? localizedStrings[title] : defaultTitle;
 
   /** Whether this webview's iframe will be populated by `src` as opposed to `srcdoc` */