Skip to content

Commit

Permalink
revert some unnecessary changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Jolie Rabideau authored and Jolie Rabideau committed Mar 26, 2024
1 parent eb21b76 commit 9ba9f35
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
3 changes: 1 addition & 2 deletions lib/papi-dts/papi.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2486,8 +2486,7 @@ declare module 'papi-shared-types' {
> = {
/**
* Set the value of the specified project setting on this project. `setSetting` must call
* `papi.projectSettings.isValid(newValue, currentValue, key, allChanges, projectType)` before
* allowing the setting change.
* `papi.projectSettings.isValid` before allowing the setting change.
*
* @param key The string id of the project setting to change
* @param newSetting The value that is to be set to the project setting.
Expand Down
3 changes: 1 addition & 2 deletions src/declarations/papi-shared-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,7 @@ declare module 'papi-shared-types' {
> = {
/**
* Set the value of the specified project setting on this project. `setSetting` must call
* `papi.projectSettings.isValid(newValue, currentValue, key, allChanges, projectType)` before
* allowing the setting change.
* `papi.projectSettings.isValid` before allowing the setting change.
*
* @param key The string id of the project setting to change
* @param newSetting The value that is to be set to the project setting.
Expand Down
4 changes: 3 additions & 1 deletion src/main/data/core-project-settings-info.data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export type AllProjectSettingsInfo = {
};

/** Info about all project settings built into core. Does not contain info for extensions' settings */
export const coreProjectSettingsInfo: Partial<AllProjectSettingsInfo> = {
const coreProjectSettingsInfo: Partial<AllProjectSettingsInfo> = {
'platform.fullName': { default: '%project_full_name_missing%' },
'platform.language': { default: '%project_language_missing%' },
'platformScripture.booksPresent': {
Expand Down Expand Up @@ -54,3 +54,5 @@ export const coreProjectSettingsValidators: Partial<AllProjectSettingsValidators
'platformScripture.booksPresent': booksPresentSettingsValidator,
'platformScripture.versification': versificationSettingsValidator,
};

export default coreProjectSettingsInfo;
3 changes: 1 addition & 2 deletions src/main/services/project-settings.service-host.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import * as networkService from '@shared/services/network.service';
import {
import coreProjectSettingsInfo, {
AllProjectSettingsInfo,
coreProjectSettingsValidators,
coreProjectSettingsInfo,
} from '@main/data/core-project-settings-info.data';
import networkObjectService from '@shared/services/network-object.service';
import {
Expand Down

0 comments on commit 9ba9f35

Please sign in to comment.