Various fixes and tweaks to prepare for demo (#1138)

paranext · Sep 11, 2024 · 7f78f35 · 7f78f35
2 parents bffc70b + 5a72c8c
commit 7f78f35
Show file tree

Hide file tree

Showing 9 changed files with 292 additions and 62 deletions.
diff --git a/assets/Lockup Inline.svg b/assets/Lockup Inline.svg
diff --git a/extensions/src/platform-scripture-editor/src/_editor-overrides.scss b/extensions/src/platform-scripture-editor/src/_editor-overrides.scss
@@ -252,21 +252,25 @@ button {
 i.add-comment {
   // could be replaced with lucid icon message-square-text
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/chat-left-text.svg');
+  background-image: none;
 }
 
 i.comments {
   // could be replaced with lucid icon messages-square
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/comments.svg');
+  background-image: none;
 }
 
 i.send {
   // could be replaced with lucid icon send
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/send.svg');
+  background-image: none;
 }
 
 .CommentPlugin_CommentsPanel_List_DeleteButton i.delete {
   // could be replaced with lucid icon trash-2
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/trash3.svg');
+  background-image: none;
   // linting does not like a duplicate rule, therefore putting it in here.
   // overwriting requires this exact selector (or a more specific one)
   left: 8px;
@@ -277,126 +281,155 @@ i.send {
 
 .link-editor div.link-edit {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/pencil-fill.svg');
+  background-image: none;
 }
 
 i.undo {
   // could be replaced with lucid icon rotate-ccw
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/arrow-counterclockwise.svg');
+  background-image: none;
 }
 
 i.redo {
   // could be replaced with lucid icon rotate-cw
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/arrow-clockwise.svg');
+  background-image: none;
 }
 
 %paragraph {
   // could be replaced with lucid icon text
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/text-paragraph.svg');
+  background-image: none;
 }
 
 %h-one {
   // could be replaced with lucid icon heading-1
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/type-h1.svg');
+  background-image: none;
 }
 
 %h-two {
   // could be replaced with lucid icon heading-2
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/type-h2.svg');
+  background-image: none;
 }
 
 %h-three {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/type-h3.svg');
+  background-image: none;
 }
 
 %square-one {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/1-square.svg');
+  background-image: none;
 }
 
 %square-two {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/2-square.svg');
+  background-image: none;
 }
 
 %square-three {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/3-square.svg');
+  background-image: none;
 }
 
 %square-four {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/4-square.svg');
+  background-image: none;
 }
 
 %bookmark {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/bookmark.svg');
+  background-image: none;
 }
 
 %file-earmark {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/file-earmark.svg');
+  background-image: none;
 }
 
 .icon.bullet-list,
 .icon.ul {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/list-ul.svg');
+  background-image: none;
 }
 
 .icon.numbered-list,
 .icon.ol {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/list-ol.svg');
+  background-image: none;
 }
 
 %quote {
   // could be replaced with lucid icon message-square-quote
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/chat-square-quote.svg');
+  background-image: none;
 }
 
 .icon.ban {
   // could be replaced with lucid icon lucide-ban
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/ban.svg');
+  background-image: none;
 }
 
 .icon.code {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/code.svg');
+  background-image: none;
 }
 
 i.bold {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/type-bold.svg');
+  background-image: none;
 }
 
 i.italic {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/type-italic.svg');
+  background-image: none;
 }
 
 i.underline {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/type-underline.svg');
+  background-image: none;
 }
 
 i.strikethrough {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/type-strikethrough.svg');
+  background-image: none;
 }
 
 i.code {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/code.svg');
+  background-image: none;
 }
 
 i.link {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/link.svg');
+  background-image: none;
 }
 
 i.left-align {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/text-left.svg');
+  background-image: none;
 }
 
 i.center-align {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/text-center.svg');
+  background-image: none;
 }
 
 i.right-align {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/text-right.svg');
+  background-image: none;
 }
 
 i.justify-align {
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/justify.svg');
+  background-image: none;
 }
 
 i.chevron-down {
   // could be replaced with lucid icon chevron-down
   -webkit-mask-image: url('papi-extension://platformScriptureEditor/assets/images/icons/chevron-down.svg');
+  background-image: none;
 }
diff --git a/lib/papi-dts/papi.d.ts b/lib/papi-dts/papi.d.ts
@@ -197,7 +197,7 @@ declare module 'shared/models/web-view.model' {
     /**
      * Whether to allow this iframe to open separate windows with window.open and anchor tags with
      * `target="_blank"`. Setting this to true adds `allow-popups` to the WebView iframe's [sandbox
-     * attribute] (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#sandbox). Defaults
+     * attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#sandbox). Defaults
      * to `false`
      */
     allowPopups?: boolean;