Skip to content

Commit

Permalink
update editor (#1348)
Browse files Browse the repository at this point in the history
- conforms to USX/USJ v3.1
  • Loading branch information
irahopkinson authored Nov 26, 2024
1 parent 03846fc commit 72a7f64
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 32 deletions.
2 changes: 1 addition & 1 deletion extensions/src/legacy-comment-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"react-dom": ">=18.3.1"
},
"dependencies": {
"@biblionexus-foundation/scripture-utilities": "~0.0.5",
"@biblionexus-foundation/scripture-utilities": "~0.0.6",
"@sillsdev/scripture": "^2.0.2",
"platform-bible-utils": "file:../../../lib/platform-bible-utils"
},
Expand Down
4 changes: 2 additions & 2 deletions extensions/src/platform-scripture-editor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
"platform-bible-utils": "file:../../../lib/platform-bible-utils"
},
"devDependencies": {
"@biblionexus-foundation/platform-editor": "~0.6.6",
"@biblionexus-foundation/scripture-utilities": "~0.0.5",
"@biblionexus-foundation/platform-editor": "~0.6.7",
"@biblionexus-foundation/scripture-utilities": "~0.0.6",
"@swc/core": "^1.7.35",
"@tailwindcss/typography": "^0.5.15",
"@types/node": "^20.16.11",
Expand Down
2 changes: 1 addition & 1 deletion extensions/src/platform-scripture/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"platform-bible-utils": "file:../../../lib/platform-bible-utils"
},
"devDependencies": {
"@biblionexus-foundation/scripture-utilities": "~0.0.5",
"@biblionexus-foundation/scripture-utilities": "~0.0.6",
"@swc/core": "^1.7.35",
"@tailwindcss/typography": "^0.5.15",
"@types/jest": "^29.5.14",
Expand Down
14 changes: 8 additions & 6 deletions lib/platform-bible-utils/src/usj-reader-writer.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Usj } from '@biblionexus-foundation/scripture-utilities';
import { Usj, USJ_TYPE, USJ_VERSION } from '@biblionexus-foundation/scripture-utilities';
import { VerseRef } from '@sillsdev/scripture';
import UsjReaderWriter from './usj-reader-writer';

Expand Down Expand Up @@ -848,9 +848,11 @@ test('Correct VerseRefs and offsets are found using findVerseRefAndOffset', () =
}).toThrow('No result found for JSONPath query: $.content[9999]');

expect(() => {
new UsjReaderWriter({ type: 'USJ', version: '0.2.1', content: [] }).jsonPathToVerseRefAndOffset(
'',
);
new UsjReaderWriter({
type: USJ_TYPE,
version: USJ_VERSION,
content: [],
}).jsonPathToVerseRefAndOffset('');
}).toThrow('Not able to determine the book ID');
});

Expand Down Expand Up @@ -926,8 +928,8 @@ test('Correct USJ details are found using findUsjContentAndJsonPath', () => {

expect(() => {
new UsjReaderWriter({
type: 'USJ',
version: '0.2.1',
type: USJ_TYPE,
version: USJ_VERSION,
content: [],
}).verseRefToUsjContentLocation(new VerseRef('JHN 1:1'), 0);
}).toThrow('Could not find JHN chapter 1');
Expand Down
44 changes: 22 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 72a7f64

Please sign in to comment.