707, 424: Fixed alignment problem when some menu items have a leading…

… icon and others don't (#786)
paranext · Mar 1, 2024 · 472c355 · 472c355
2 parents 4d3968b + 3d8b977
commit 472c355
Show file tree

Hide file tree

Showing 5 changed files with 281 additions and 277 deletions.
diff --git a/lib/platform-bible-react/dist/index.cjs b/lib/platform-bible-react/dist/index.cjs
diff --git a/lib/platform-bible-react/dist/index.cjs.map b/lib/platform-bible-react/dist/index.cjs.map
diff --git a/lib/platform-bible-react/dist/index.js b/lib/platform-bible-react/dist/index.js
diff --git a/lib/platform-bible-react/dist/index.js.map b/lib/platform-bible-react/dist/index.js.map
diff --git a/lib/platform-bible-react/src/components/grouped-menu-item-list.component.tsx b/lib/platform-bible-react/src/components/grouped-menu-item-list.component.tsx
@@ -143,7 +143,9 @@ export default function GroupedMenuItemList(menuProps: GroupedMenuItemListProps)
     // No divider after last item in final group.
     if (itemArray.length > 0) itemArray[itemArray.length - 1].isLastItemInGroup = false;
 
-    const allowSpaceForLeadingIcons = itemArray.some((i) => 'iconPathBefore' in i);
+    const allowSpaceForLeadingIcons = itemArray.some(
+      (i) => 'iconPathBefore' in i.item && i.item.iconPathBefore,
+    );
 
     return { items: itemArray, allowForLeadingIcons: allowSpaceForLeadingIcons };
   }, [includedGroups, menuDefinition]);