Skip to content

Commit

Permalink
Fix typedoc build problems (#751)
Browse files Browse the repository at this point in the history
  • Loading branch information
lyonsil authored Feb 5, 2024
1 parent c8660c5 commit 0e01c5d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/platform-bible-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"scripts": {
"start": "vite --host --open",
"build:basic": "tsc && vite build && dts-bundle-generator --config ./dts-bundle-generator.config.ts",
"build:docs": "typedoc",
"build:docs": "npm install && typedoc",
"build": "npm run build:basic && npm run lint-fix",
"watch": "tsc && vite build --watch",
"lint": "npm run lint:scripts",
Expand Down
4 changes: 1 addition & 3 deletions lib/platform-bible-utils/src/document-combiner-engine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ export default abstract class DocumentCombinerEngine {
* Create a DocumentCombinerEngine instance
*
* @param baseDocument This is the first document that will be used when composing the output
* @param copyDocuments If true, this instance will perform a deep copy of all provided documents
* before composing the output. If false, then changes made to provided documents after they are
* contributed will be reflected in the next time output is composed.
* @param options Options used by this object when combining documents
*/
protected constructor(baseDocument: JsonDocumentLike, options: DocumentCombinerOptions) {
// Setting baseDocument redundantly because TS doesn't understand that updateBaseDocument does it
Expand Down
2 changes: 1 addition & 1 deletion lib/platform-bible-utils/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export type {
export type { PlatformEventHandler, PlatformEvent, PlatformEventAsync } from './platform-event';
export type { ScriptureReference, BookInfo } from './scripture.model';
export type { Unsubscriber, UnsubscriberAsync } from './unsubscriber';
export type { JsonDocumentLike } from './document-combiner-engine';
export type { DocumentCombinerOptions, JsonDocumentLike } from './document-combiner-engine';
export type {
LocalizeKey,
ReferencedItem,
Expand Down
2 changes: 1 addition & 1 deletion lib/platform-bible-utils/src/serialization.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function serialize(
* values, you should wrap them yourself in a string before using this function. Alternatively, you
* can write your own replacer that will preserve `null` in a way that you can recover later.
*
* @param text A valid JSON string.
* @param value A valid JSON string.
* @param reviver A function that transforms the results. This function is called for each member of
* the object. If a member contains nested objects, the nested objects are transformed before the
* parent object is. Note that `null` values are converted into `undefined` values after the
Expand Down

0 comments on commit 0e01c5d

Please sign in to comment.