Skip to content

Commit

Permalink
Fix rtl for NavigationContentSearch (#1108)
Browse files Browse the repository at this point in the history
  • Loading branch information
jolierabideau authored Sep 3, 2024
2 parents c3f115e + 7f57af5 commit 0944f8d
Show file tree
Hide file tree
Showing 7 changed files with 203 additions and 195 deletions.
188 changes: 94 additions & 94 deletions lib/platform-bible-react/dist/index.cjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/platform-bible-react/dist/index.cjs.map

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion lib/platform-bible-react/dist/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -930,8 +930,10 @@ export type NavigationContentSearchProps = {
headerTitle?: string;
/** Optional flag to make the search bar appear full width */
isSearchBarFullWidth?: boolean;
/** Text direction ltr or rtl */
direction?: "ltr" | "rtl";
};
export function NavigationContentSearch({ tabList, onSearch, searchPlaceholder, headerTitle, isSearchBarFullWidth, }: NavigationContentSearchProps): import("react/jsx-runtime").JSX.Element;
export function NavigationContentSearch({ tabList, onSearch, searchPlaceholder, headerTitle, isSearchBarFullWidth, direction, }: NavigationContentSearchProps): import("react/jsx-runtime").JSX.Element;
/** Props for the SettingsList component, currently just children */
export type SettingsListProps = React$1.PropsWithChildren;
/**
Expand Down
195 changes: 98 additions & 97 deletions lib/platform-bible-react/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/platform-bible-react/dist/index.js.map

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ export type NavigationContentSearchProps = {

/** Optional flag to make the search bar appear full width */
isSearchBarFullWidth?: boolean;

/** Text direction ltr or rtl */
direction?: 'ltr' | 'rtl';
};

export default function NavigationContentSearch({
Expand All @@ -36,6 +39,7 @@ export default function NavigationContentSearch({
searchPlaceholder,
headerTitle,
isSearchBarFullWidth = false,
direction = 'ltr',
}: NavigationContentSearchProps) {
return (
<div className="pr-twp">
Expand All @@ -47,7 +51,7 @@ export default function NavigationContentSearch({
placeholder={searchPlaceholder}
/>
</div>
<VerticalTabs>
<VerticalTabs dir={direction}>
<VerticalTabsList>
{tabList.map((tab) => (
<VerticalTabsTrigger key={tab.key} value={tab.value}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ function Compositions({ direction }: HasDirection) {
onSearch={handleSearchChange}
searchPlaceholder="Search..."
isSearchBarFullWidth
direction={direction}
/>
</VerticalTabsContent>

Expand Down

0 comments on commit 0944f8d

Please sign in to comment.