There is no pleasing Psalm, so let's just disable this check.

paragonie · Mar 3, 2017 · 6968531 · 6968531
1 parent ae8d957
commit 6968531
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/lib/cast_to_int.php b/lib/cast_to_int.php
@@ -49,7 +49,7 @@ function RandomCompat_intval($number, $fail_open = false)
         if (is_int($number) || is_float($number)) {
             $number += 0;
         } elseif (is_numeric($number)) {
-            $number = (int) $number;
+            $number += 0;
         }
 
         if (

diff --git a/psalm.xml b/psalm.xml
@@ -8,6 +8,7 @@
         <directory name="lib" />
     </projectFiles>
     <issueHandlers>
+        <InvalidOperand errorLevel="info" />
         <UndefinedConstant errorLevel="info" />
         <MissingReturnType errorLevel="info" />
     </issueHandlers>

diff --git a/tests/unit/RandomIntTest.php b/tests/unit/RandomIntTest.php
@@ -33,8 +33,8 @@ public function testOutput()
         $this->assertTrue($integers[6] === 0);
         $this->assertTrue($integers[7] >= $half_neg_max && $integers[7] <= PHP_INT_MAX);
         $this->assertTrue($integers[8] >= 0 && $integers[8] <= 255);
-        $this->assertTrue($integers[9] === -4);
-        $this->assertTrue($integers[10] === 1337000);
+        $this->assertSame($integers[9], -4);
+        $this->assertSame($integers[10], 1337000);
 
         try {
             $h = random_int("2147483648", "2147483647");