Fix stubs. Remove UndefinedClass suppression.

lib/random_bytes_com_dotnet.php

@@ -55,6 +55,11 @@ function random_bytes($bytes)
         }
 
         $buf = '';
+        if (!class_exists('COM')) {
+            throw new Error(
+                'COM does not exist'
+            );
+        }
         $util = new COM('CAPICOM.Utilities.1');
         $execCount = 0;
 

lib/random_bytes_libsodium_legacy.php

@@ -72,7 +72,7 @@ function random_bytes($bytes)
             $buf = Sodium::randombytes_buf($bytes);
         }
 
-        if ($buf !== false) {
+        if (is_string($buf)) {
             if (RandomCompat_strlen($buf) === $bytes) {
                 return $buf;
             }

other/ide_stubs/COM.php

@@ -15,12 +15,6 @@ class COM
      */
     public function GetRandom($bytes, $dummy)
     {
-        static $fp = null;
-        if (!$fp) {
-            $fp = fopen('/dev/urandom', 'rb');
-        }
-        return fread($fp, $bytes);
+        return '';
     }
 }
-
-throw new Exception('Attempting to include IDE stub files in a project.');

other/ide_stubs/README.md

@@ -2,4 +2,6 @@
 
 These exist to reduce false positive errors on PHPStorm and other IDEs.
 
+They also exist so Psalm has some idea what's going on.
+
 Don't use them in your project.

other/ide_stubs/com_exception.php

@@ -9,5 +9,3 @@ class com_exception extends Exception
 {
 
 }
-
-throw new Exception('Attempting to include IDE stub files in a project.');

other/ide_stubs/libsodium.php

@@ -1,46 +1,90 @@
 <?php
-namespace Sodium;
 
 /**
  * This does nothing if the libsodium extension is loaded, so it's harmless.
  *
  * This file alone is released under CC0 and WTFPL dual licensing.
  */
-if (!extension_loaded('libsodium')) {
+namespace Sodium {
+    if (!extension_loaded('libsodium')) {
 
-    /**
-     * Generate a string of random bytes
-     * /dev/urandom
-     *
-     * @param int $length
-     * @return string
-     */
-    function randombytes_buf(
-        $length
-    ) {
-        return '';
-    }
+        /**
+         * Generate a string of random bytes
+         * /dev/urandom
+         *
+         * @param int $length
+         * @return string
+         */
+        function randombytes_buf(
+            $length
+        )
+        {
+            return '';
+        }
 
-    /**
-     * Generate a 16-bit integer
-     * /dev/urandom
-     *
-     * @return int
-     */
-    function randombytes_random16() {
-        return '';
-    }
+        /**
+         * Generate a 16-bit integer
+         * /dev/urandom
+         *
+         * @return int
+         */
+        function randombytes_random16()
+        {
+            return '';
+        }
 
-    /**
-     * Generate an unbiased random integer between 0 and a specified value
-     * /dev/urandom
-     *
-     * @param int $upperBoundNonInclusive
-     * @return int
-     */
-    function randombytes_uniform(
-        $upperBoundNonInclusive
-    ) {
-        return 0;
+        /**
+         * Generate an unbiased random integer between 0 and a specified value
+         * /dev/urandom
+         *
+         * @param int $upperBoundNonInclusive
+         * @return int
+         */
+        function randombytes_uniform(
+            $upperBoundNonInclusive
+        )
+        {
+            return 0;
+        }
     }
 }
+namespace {
+    class Sodium
+    {
+
+        /**
+         * Generate a string of random bytes
+         * /dev/urandom
+         *
+         * @param int $length
+         * @return string
+         */
+        public static function randombytes_buf($length)
+        {
+            return '';
+        }
+
+        /**
+         * Generate a 16-bit integer
+         * /dev/urandom
+         *
+         * @return int
+         */
+        public static function randombytes_random16()
+        {
+            return '';
+        }
+
+        /**
+         * Generate an unbiased random integer between 0 and a specified value
+         * /dev/urandom
+         *
+         * @param int $upperBoundNonInclusive
+         * @return int
+         */
+        public static function randombytes_uniform($upperBoundNonInclusive = 0)
+        {
+            return 0;
+        }
+    }
+}

psalm.xml

@@ -9,7 +9,6 @@
     </projectFiles>
     <issueHandlers>
         <DuplicateClass errorLevel="info" />
-        <UndefinedClass errorLevel="info" />
         <FailedTypeResolution errorLevel="info" />
         <InvalidArgument errorLevel="info" />
         <InvalidOperand errorLevel="info" />