Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify unchecked naming #13391

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore: unify unchecked naming #13391

merged 1 commit into from
Dec 13, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 13, 2024

across the codebase base these types of functions are called _unchecked.

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Dec 13, 2024
Rjected
Rjected approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse enabled auto-merge December 13, 2024 18:23
@mattsse mattsse added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit a7ebd15 Dec 13, 2024
43 checks passed
@mattsse mattsse deleted the matt/rename-seal- branch December 13, 2024 18:46
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
@mattsse @emhane
chore: unify unchecked naming (paradigmxyz#13391)
2690d7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected