Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ethereum-specific transaction #13368

Merged
merged 5 commits into from
Dec 12, 2024
Merged

feat: ethereum-specific transaction #13368

merged 5 commits into from
Dec 12, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 12, 2024

Extracts TransactionSigned part without optimism-gated logic to reth-ethereum-primitives, unused for now

wip

Verified

This commit was signed with the committer’s verified signature.
klkvr Arsenii Kulikov
fix

Verified

This commit was signed with the committer’s verified signature.
klkvr Arsenii Kulikov
fix

Verified

This commit was signed with the committer’s verified signature.
klkvr Arsenii Kulikov
fix

Verified

This commit was signed with the committer’s verified signature.
klkvr Arsenii Kulikov
fix

Verified

This commit was signed with the committer’s verified signature.
klkvr Arsenii Kulikov
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

Comment on lines +27 to +37
macro_rules! delegate {
($self:expr => $tx:ident.$method:ident($($arg:expr),*)) => {
match $self {
Transaction::Legacy($tx) => $tx.$method($($arg),*),
Transaction::Eip2930($tx) => $tx.$method($($arg),*),
Transaction::Eip1559($tx) => $tx.$method($($arg),*),
Transaction::Eip4844($tx) => $tx.$method($($arg),*),
Transaction::Eip7702($tx) => $tx.$method($($arg),*),
}
};
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@klkvr klkvr added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 8f262e5 Dec 12, 2024
42 checks passed
@klkvr klkvr deleted the klkvr/eth-tx branch December 12, 2024 23:48
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024

Verified

This commit was signed with the committer’s verified signature.
emhane Emilia Hane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants