feat(ethereum-forks): remove total difficulty for hardfork check #13362
Conversation
|
@mattsse, is this how you were thinking of removing total difficulty and relying solely on the block number (given Paris is always the merge fork)? |
| /// The fork is activated after a total difficulty has been reached. | ||
| TTD { | ||
| /// The block number at which TTD is reached, if it is known. | ||
| /// | ||
| /// This should **NOT** be set unless you want this block advertised as [EIP-2124][eip2124] | ||
| /// `FORK_NEXT`. This is currently only the case for Sepolia and Holesky. | ||
| /// | ||
| /// [eip2124]: https://eips.ethereum.org/EIPS/eip-2124 | ||
| fork_block: Option<BlockNumber>, | ||
| /// The total difficulty after which the fork is activated. | ||
| total_difficulty: U256, | ||
| }, |
There was a problem hiding this comment.
hmm, this has implications on the forkid.
I think the way we should go about this is keeping this variant but requiring that it knows the block number
@Rjected @joshieDo I can't remember what the implications of the fork_block field are because we set this.
I think we can't just set the fork_block field because this messes with the forkid, for example for mainnet we must set this to none,
so to enforce a block number for ttd we should add a new field
There was a problem hiding this comment.
yes, we need to keep one eip-2124 fork block at least. We would want another blocknum field, that is used for checking if the merge is active, but not for the forkid.
|
@aroralanuk so the way we should solve this is, we keep the |
(note: this PR won't be compiling right now)