Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm pooledtx element type #13286

Merged
merged 11 commits into from
Dec 13, 2024
Merged

chore: rm pooledtx element type #13286

merged 11 commits into from
Dec 13, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 11, 2024

Removes the PooledTransactionElement and replaces it with the alloy PooledTransaction.

this keeps an alias to keep changes small in this pr.

will rename next.

I've flipped the try_from conversion so we can still use TxSigned -> PooledTx conversions

@mattsse mattsse changed the title wip:chore: rm pooledtx element type chore: rm pooledtx element type Dec 13, 2024
@mattsse mattsse marked this pull request as ready for review December 13, 2024 12:15
@mattsse mattsse added the A-sdk Related to reth's use as a library label Dec 13, 2024
@mattsse mattsse requested a review from gakonst as a code owner December 13, 2024 12:26
Copy link
Collaborator

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit acc125a Dec 13, 2024
42 checks passed
@mattsse mattsse deleted the matt/rm-pooled-tx-element branch December 13, 2024 13:13
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants