fix: only terminate the stream if range is empty #13281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/fix-parallelism-one
branch
from
7610cb4 to
cfdb9c9
Compare
mattsse
added
C-bug
shekhirin
reviewed
Dec 11, 2024
Co-authored-by: Alexey Shekhirin <[email protected]>
shekhirin
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13279
@shekhirin this fixes a logic bug that would terminate the entire stream after the first task because we'd end up
here
reth/crates/exex/exex/src/backfill/stream.rs
Line 113 in 7610cb4
but the range can still have blocks
perhaps there's a nicer way to solve this