feat(engine): integrate state root task and comment it #13265
+141
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/state-root-task-integrate
branch
from
b4f0790 to
71f5252
Compare
This reverts commit f0487b9.
… alexey/state-root-task-integrate
shekhirin
force-pushed
the
alexey/state-root-task-integrate
branch
5 times, most recently
from
30c6ee9 to
dab362e
Compare
shekhirin
force-pushed
the
alexey/state-root-task-integrate
branch
from
dab362e to
a20b19b
Compare
shekhirin
requested review from
rkrasiuk,
mattsse,
Rjected and
fgimenez
as code owners
fgimenez
reviewed
Dec 12, 2024
| let noop_state_hook = |_state: &EvmState| {}; | ||
| let persistence_not_in_progress = !self.persistence_state.in_progress(); | ||
|
|
||
| // TODO: uncomment to use StateRootTask |
There was a problem hiding this comment.
This doesn't include the changes for using the std::thread::scope that spawning StateRootTask requires now
There was a problem hiding this comment.
yep true, but they were quite invasive because it requires a huge scope that different stuff gets in, and also a custom return from that scope. So I decided to leave it for the wiring PR.
fgimenez
approved these changes
Dec 12, 2024
rkrasiuk
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't enable the state root task, but instead just integrates it commented into the main codepath. This makes the testing easier, so that the "wiring" PR will be only about uncommenting these lines.