-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(engine): sparse trie calculation for state root task #12843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into alexey/state-root-task-calculate-sparse
shekhirin
changed the base branch from
main
to
alexey/sparse-state-trie-methods
November 25, 2024 10:59
…' into alexey/state-root-task-calculate-sparse
shekhirin
force-pushed
the
alexey/state-root-task-calculate-sparse
branch
from
November 25, 2024 11:08
c25f9a7
to
b420f4d
Compare
…' into alexey/state-root-task-calculate-sparse
…k-calculate-sparse
shekhirin
added
C-perf
A change motivated by improving speed, memory usage or disk footprint
A-trie
Related to Merkle Patricia Trie implementation
labels
Nov 25, 2024
shekhirin
requested review from
Rjected,
mattsse,
fgimenez and
gakonst
as code owners
November 25, 2024 13:49
rkrasiuk
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a function for update the sparse trie according to the provided multiproof, targets and updated state. When #12458 is merged, it will be integrated into the state root task.