Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
This PR builds on #11872 and should be reviewed after #11872 is merged
Overview
We need to make the
HashedStorage
generic over theKeyHasher
such that we can instantiateHashedStorage
with different key hashing algorithms. We modifyHashedStorage::from_plain_storage
and introduceHashedStorage::from_bundle_account
(for convenience) such that we have the following signatures:The
BundleStateProvider
needs to invoke this method as seen below:reth/crates/storage/provider/src/providers/bundle_state_provider.rs
Lines 29 to 48 in 9c8f5d8
Therefore we either need to make the
StateCommitment
type available inBundleStateProvider
by the introduction of an additional generic andPhantonData
marker or alternatively introduce aHashedStorageProvider
trait and add it to theStateProvider
supertrait such that we can leverage theStateProvider
that theBundleStateProvider
has to create theHashedStorage
object. This PR takes the latter approach but I would seek guidance from maintainers on what is the preferred approach.supports: #11830