Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Icon.colorize property in ListItem.Standard #413

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Expose Icon.colorize property in ListItem.Standard #413

wants to merge 2 commits into from

Conversation

MaxMansfield
Copy link

Brief:

This is a very simple addition to help development of the papyros/files-app.
It allows a user to choose whether the icon on a ListItem.Standard
is colorized or not. In a ListItem.Standard a user can now use the
property colorizeIcon: which takes a bool and is an alias for icon.colorize in the
ListItem.Standard.

This came to be an issue when attempting to list mimetype icons
in the papyros files app as they were all using a ColorOverlay instead
of an image.

Changes:

1. Added a `colorizeIcon:` property in `ListItem.Standard`
   which allows a user to turn the `ColorOverlay` on and
   off at will.

Data:

Here's what I get when I have no control over icon.colorize

before_colorize

As you can see the icons (test icons) that I need to be shown as images are shown with an overlay

### The results of `colorizeIcon: false`

after_colorize

Now the test icons show up and I can begin implementing the mimetype logic

### Here's what the `colorizeIcon:` property looks like when used

colorizecode


###### Line 31: How `colorizeIcon:` would be used.

I know that the files-app is using an earlier version of qml-material than what's on develop but it would still be a useful property and would give incentive to migrate the files app to a newer version of qml-material when the time comes

This is a very simple addition for development of the papyros/files-app.
It allows a user to choose whether the icon on a ListItem.Standard
is colorized or not. In a ListItem.Standard a user can now use the
field "colorizeIcon:" which is an alias for "icon.colorize" in the
item.

This came to be an issue when attempting to list mimetype icons
in the papyros files app as they were all using a ColorOverlay instead
of an image.

Changes:
	1. Added a colorizeIcon property in ListItem.Standard
	   which allows a user to turn the ColorOverlay on and
	   off at will.
@MaxMansfield
Copy link
Author

MaxMansfield commented Apr 14, 2016

The problems addressed in Issue #406 caused Travis CI to fail.

The demo application is missing a dependency. This commit fixes it
which will allow Travis CI to run reliably.

Changes:
	1. Copied the icons/navigation_menu.svg
	   file to the demo/icons folder
@MaxMansfield
Copy link
Author

My pull request now includes a fix to issue #406 so that it could pass the CI tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant