Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Refactor each process as module, and fix matched/unmatched mode #4

Merged
merged 21 commits into from
Dec 24, 2024

Conversation

juanesarango
Copy link
Contributor

@juanesarango juanesarango commented Dec 24, 2024

Following up with #2, in this branch I fix several things:

  • refactor each process as module for better organization.
  • fix the issue were outputs were not being cached and we relied on a conditional and symlink.
  • fix the issues with optional outputs and optional inputs following nextflow patterns.
  • each module has an unit test to check with matched and unmatched params.
├── assets
│   └── NO_FILE
├── bin
│   └── bin_cobalt.py
├── modules
│   ├── amber.nf
│   ├── cobalt.nf
│   ├── purple.nf
│   └── sage.nf
├── tests
│   ├── module.binCobalt.nf.test
│   ├── module.runAmber.nf.test
│   ├── module.runAmber.nf.test.snap
│   ├── module.runCobalt.nf.test
│   ├── module.runCobalt.nf.test.snap
│   ├── module.runPurple.nf.test
│   ├── module.runSage.nf.test
│   ├── nextflow.config
│   └── workflow.main.nf.test
├── main.nf
├── nextflow.config
├── nf-test.config
├── Dockerfile
└── README.md

@juanesarango juanesarango requested a review from Copilot December 24, 2024 05:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 43 out of 59 changed files in this pull request and generated 1 comment.

Files not reviewed (16)
  • main.nf: Language not supported
  • modules/amber.nf: Language not supported
  • modules/cobalt.nf: Language not supported
  • modules/purple.nf: Language not supported
  • modules/sage.nf: Language not supported
  • nextflow.config: Language not supported
  • nf-test.config: Language not supported
  • run_matched.sh: Language not supported
  • run_sage.sh: Language not supported
  • run_unmatched.sh: Language not supported
  • tests/data/amber/TEST_TUMOR.amber.baf.pcf: Language not supported
  • tests/data/amber/TEST_TUMOR.amber.qc: Language not supported
  • tests/data/cobalt/TEST_NORMAL.cobalt.ratio.pcf: Language not supported
  • tests/data/cobalt/TEST_TUMOR.cobalt.ratio.pcf: Language not supported
  • tests/data/cobalt/binned_100_probes_0.5_LogR/TEST_NORMAL.cobalt.ratio.pcf: Language not supported
  • tests/data/cobalt/binned_100_probes_0.5_LogR/TEST_TUMOR.cobalt.ratio.pcf: Language not supported

tests/data/README.md Outdated Show resolved Hide resolved
@juanesarango juanesarango mentioned this pull request Dec 24, 2024
6 tasks
@juanesarango juanesarango merged commit 937606c into main Dec 24, 2024
1 check passed
@juanesarango juanesarango deleted the refactor-main branch December 24, 2024 06:04
@ddomenico
Copy link
Contributor

All very necessary changes, nice work! 👍 LGTM, let's try for some tests comparing matched runs to Battenberg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants