Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Docusaurus to 3.5 #253

Merged
merged 2 commits into from
Aug 23, 2024
Merged

update Docusaurus to 3.5 #253

merged 2 commits into from
Aug 23, 2024

Conversation

cburroughs
Copy link
Contributor

I don't have any fancy Javascript skills, I just blindly ran yarn upgrade to bump everything in the lockfile since I was annoyed by the upgrade warnings.

Release highlights (each links to detailed changelogs):

I don't have any fancy Javascript skills, I just blindly ran `yarn
upgrade` to bump everything in the lockfile.

Release highlights (each links to detailed changelogs):
 * https://docusaurus.io/blog/releases/3.1
 * https://docusaurus.io/blog/releases/3.2
 * https://docusaurus.io/blog/releases/3.3
 * https://docusaurus.io/blog/releases/3.4
 * https://docusaurus.io/blog/releases/3.5
@cburroughs cburroughs self-assigned this Aug 22, 2024
@cburroughs
Copy link
Contributor Author

To test I ran the blog locally, and also ran NODE_OPTIONS="--max-old-space-size=12288" npm run build and clicked around a bunch.

@@ -4,7 +4,7 @@ import {
useActiveDocContext,
} from "@docusaurus/plugin-content-docs/client";
import { useDocsPreferredVersion } from "@docusaurus/theme-common";
import { useDocsVersionCandidates } from "@docusaurus/theme-common/internal";
import { useDocsVersionCandidates } from '@docusaurus/plugin-content-docs/client';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find a reference to this in the release notes, I think it falls through the semver cracks as an "internal" api.

Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this one.

Maybe the build is slightly faster with the optimisations in 3.2, but definitely not 30% 😢

@cburroughs cburroughs merged commit 9a00f62 into main Aug 23, 2024
1 check passed
@cburroughs cburroughs deleted the csb/docu-up branch August 23, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants