Escape $'s in reference default values #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This escapes
$
in default values to avoid them being treated as template literal substitutions.Default values end up in a template literal
`something`
. If the string contains${...}
literally, they'll be treated as a substitution. This PR escapes all$
s to avoid this.This bug/oversight doesn't cause problems with any current values, but will be required in 2.23.0.dev4 due to the new default value for
output_path
fields from pantsbuild/pants#21175.Example of the effect (from #234 (comment)):