Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAN-2133] [PAN-2135] [PAN-2148] Database access improvements #91

Merged
merged 2 commits into from
Aug 26, 2024
Merged

[PAN-2133] [PAN-2135] [PAN-2148] Database access improvements #91

merged 2 commits into from
Aug 26, 2024

Conversation

markuslevonyak
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR improves the database access module:

  • Nested database transactions are used instead of thread locking to deal with potential race conditions during creating hub, forwarder, and token contract instances.
  • Some SQLAlchemy 1.x relics are removed and replaced with proper SQLAlchemy 2.x code.

@markuslevonyak markuslevonyak added the enhancement New feature or request label Aug 23, 2024
@markuslevonyak markuslevonyak self-assigned this Aug 23, 2024
@markuslevonyak markuslevonyak merged commit 9ac0e4b into pantos-io:main Aug 26, 2024
15 checks passed
@markuslevonyak markuslevonyak deleted the PAN-2133-2135-2148-database-access-improvements branch August 26, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danut13 danut13 danut13 approved these changes

@jacekv jacekv jacekv approved these changes

@chandraprakash chandraprakash Awaiting requested review from chandraprakash

Assignees

@markuslevonyak markuslevonyak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markuslevonyak @jacekv @danut13