Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Added missing variables to CI #682

Merged
merged 1 commit into from
Aug 31, 2024
Merged

💚 Added missing variables to CI #682

merged 1 commit into from
Aug 31, 2024

Conversation

rflihxyz
Copy link
Contributor

@rflihxyz rflihxyz commented Aug 31, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced build process for the dashboard with new environment variables for webhook handling and web application domain configuration.
    • Improved deployment capabilities of the frontend dashboard through the addition of new build arguments.

@naelob
Copy link
Contributor

naelob commented Aug 31, 2024

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 783d0240-ec38-4387-a9a9-8e225f1bd3e1 dev
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Help yourself at 2AM by putting some metrics to help observability

Copy link

changeset-bot bot commented Aug 31, 2024

⚠️ No Changeset found

Latest commit: 957900e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rflihxyz rflihxyz merged commit 4ba01b5 into main Aug 31, 2024
11 of 14 checks passed
Copy link
Contributor

coderabbitai bot commented Aug 31, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The changes involve modifications to two GitHub Actions workflow files, enhancing the build configuration by adding two new environment variables: NEXT_PUBLIC_REDIRECT_WEBHOOK_INGRESS and NEXT_PUBLIC_WEBAPP_DOMAIN. These variables are sourced from repository secrets and environment variables, respectively, allowing the build process to accommodate new functionalities related to webhook handling and web application domain configuration.

Changes

Files Change Summary
.github/workflows/docker.check-build.dashboard.selfhosted.yml, .github/workflows/docker.export.frontend-dashboard.selfhosted.yml Added NEXT_PUBLIC_REDIRECT_WEBHOOK_INGRESS and NEXT_PUBLIC_WEBAPP_DOMAIN environment variables; no changes to existing variables.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

zeropath-ai bot commented Aug 31, 2024

ZeroPath has finished reviewing your PR. The PR adds two new environment variables, NEXT_PUBLIC_REDIRECT_WEBHOOK_INGRESS and NEXT_PUBLIC_WEBAPP_DOMAIN, to the build arguments in two GitHub workflow files for Docker builds. We have found no vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants