🩺 Healthchecks in docker #469
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughThis update involves several key changes: the introduction of Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added healthchecks to
docker-compose.dev.yml,docker-compose.source.yml, anddocker-compose.yml - Removed unused Stytch and Minio environment variables from
.env.example - Introduced
BACKEND_PORTandPORTenvironment variables - Updated
depends_onconditions indocker-compose.ymlfor better service startup - Added
netcat-openbsdandcurltopackages/api/Dockerfilefor healthcheck support
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (3)
packages/api/Dockerfile (3)
Line range hint
6-7: Consolidate consecutive RUN instructions and pin package versions.- RUN apk add --no-cache libc6-compat - RUN apk update + RUN apk update && \ + apk add --no-cache libc6-compat=<version>
Line range hint
22-23: Consolidate consecutive RUN instructions and pin package versions.- RUN apk add --no-cache libc6-compat - RUN apk update + RUN apk update && \ + apk add --no-cache libc6-compat=<version>
Line range hint
57-57: Use JSON notation for CMD to ensure correct parsing.- CMD node dist/src/main.js + CMD ["node", "dist/src/main.js"]
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
docker-compose.dev.ymlis excluded by!**/*.ymldocker-compose.source.ymlis excluded by!**/*.ymldocker-compose.ymlis excluded by!**/*.yml
Files selected for processing (2)
- .env.example (3 hunks)
- packages/api/Dockerfile (1 hunks)
Additional Context Used
Hadolint (6)
packages/api/Dockerfile (6)
6: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
7: Multiple consecutive
RUNinstructions. Consider consolidation.
22: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
23: Multiple consecutive
RUNinstructions. Consider consolidation.
45: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
57: Use arguments JSON notation for CMD and ENTRYPOINT arguments
Additional comments not posted (3)
.env.example (3)
9-9: Setting for BACKEND_PORT looks good.
11-11: SENTRY_DSN placeholder is correctly unset in the example file.
79-79: Disabling Next.js telemetry with NEXT_TELEMETRY_DISABLED is correctly implemented.
| @@ -42,6 +42,8 @@ RUN pnpm run build | |||
|
|
|||
| # ======================================================================== | |||
| FROM base AS runner | |||
| RUN apk add --no-cache libc6-compat netcat-openbsd curl | |||
There was a problem hiding this comment.
Pin versions of packages to ensure consistent builds.
- RUN apk add --no-cache libc6-compat netcat-openbsd curl
+ RUN apk add --no-cache libc6-compat=<version> netcat-openbsd=<version> curl=<version>Committable suggestion was skipped due low confidence.
Adding healthchecks to Docker-compose