Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Docs update #456

Merged
merged 6 commits into from
May 23, 2024
Merged

📝 Docs update #456

merged 6 commits into from
May 23, 2024

Conversation

naelob
Copy link
Contributor

@naelob naelob commented May 23, 2024

No description provided.

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
panora-client-ts ❌ Failed (Inspect) May 23, 2024 9:46pm

Copy link

changeset-bot bot commented May 23, 2024

⚠️ No Changeset found

Latest commit: dddb15d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

coderabbitai bot commented May 23, 2024

Warning

Rate Limit Exceeded

@naelob has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 35 minutes and 42 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between b7ff242 and dddb15d.

Walkthrough

The recent updates enhance the documentation by replacing images with video elements for better visual guidance, refining descriptions, and adding new sections with detailed instructions and code examples. The changes also include updates to method names and query parameters in the API, ensuring clarity and consistency in naming conventions.

Changes

Files/Paths Change Summary
docs/core-concepts/custom-fields.mdx Updated video description, added video element, renamed steps for custom field mappings, added API section with examples.
docs/core-concepts/magic-links.mdx Replaced an image with a video element, added instructions for creating a Magic Link.
docs/quick-start.mdx Updated links, added connector card/catalog details, fixed typos, added props details.
docs/recipes/add-custom-provider-creds.mdx Replaced an image with a video element.
docs/recipes/import-existing-users.mdx Added instructions for importing users via UI and API, with examples.
packages/api/src/@core/linked-users/... Updated method names and query parameters for getLinkedUsers and getLinkedUserV2.

In docs, where knowledge blooms anew,
Videos now guide, with clarity in view.
Field mappings renamed, steps redefined,
API examples, neatly aligned.
Magic Links and users, all set to thrive,
With every update, we keep docs alive.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8011abf and 162121e.
Files ignored due to path filters (8)
  • docs/images/apikeys.mp4 is excluded by !**/*.mp4, !**/*.mp4
  • docs/images/customcreds.mp4 is excluded by !**/*.mp4, !**/*.mp4
  • docs/images/definefields.mp4 is excluded by !**/*.mp4, !**/*.mp4
  • docs/images/linkedusers.mp4 is excluded by !**/*.mp4, !**/*.mp4
  • docs/images/magiclinks.mp4 is excluded by !**/*.mp4, !**/*.mp4
  • docs/images/webhooks.mp4 is excluded by !**/*.mp4, !**/*.mp4
  • docs/mint.json is excluded by !**/*.json
  • packages/api/swagger/swagger-spec.json is excluded by !**/*.json
Files selected for processing (6)
  • docs/core-concepts/custom-fields.mdx (2 hunks)
  • docs/core-concepts/magic-links.mdx (2 hunks)
  • docs/quick-start.mdx (3 hunks)
  • docs/recipes/add-custom-provider-creds.mdx (1 hunks)
  • docs/recipes/import-existing-users.mdx (1 hunks)
  • packages/api/src/@core/linked-users/linked-users.controller.ts (2 hunks)
Files skipped from review due to trivial changes (3)
  • docs/quick-start.mdx
  • docs/recipes/add-custom-provider-creds.mdx
  • docs/recipes/import-existing-users.mdx
Additional Context Used
Biome (9)
packages/api/src/@core/linked-users/linked-users.controller.ts (9)

41-41: Decorators are not valid here.


53-53: Decorators are not valid here.


64-64: Decorators are not valid here.


77-77: Decorators are not valid here.


90-90: Decorators are not valid here.


64-64: Unexpected any. Specify a different type.


11-11: All these imports are only used as types.


12-12: All these imports are only used as types.


Import statements could be sorted:

Additional comments not posted (8)
docs/core-concepts/magic-links.mdx (3)

8-12: The replacement of the image with a video is a great enhancement for user engagement and clarity.


21-24: The updated instructions for creating a Magic Link are clear and well-formatted.


31-33: Adding the option to select a Linked User enhances flexibility and user experience.

packages/api/src/@core/linked-users/linked-users.controller.ts (2)

57-63: The method name change to fetchLinkedUsers better reflects the retrieval action, and the updated documentation is clear.


82-89: The method name linkedUserFromRemoteId and the parameter change to remoteId clarify the function's purpose. The route update is also appropriate.

docs/core-concepts/custom-fields.mdx (3)

14-22: The inclusion of a video to demonstrate field mapping is an excellent enhancement for visual learners.


33-38: Renaming the steps to be more action-oriented ("Define a custom field" and "Map a custom field") improves clarity and user guidance.


50-81: The new section on creating custom field mappings using the API is well-documented and provides valuable guidance for API users.

></video>
</Frame>

## Create a custom field mapping using the our UI dashboard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the grammatical error in the introduction to the section on creating a custom field mapping.

- using the our UI dashboard
+ using our UI dashboard

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
## Create a custom field mapping using the our UI dashboard
## Create a custom field mapping using our UI dashboard

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range and nitpick comments (1)
docs/recipes/embed-catalog.mdx (1)

7-7: Consider replacing "insert video" with a proper video tag or markdown.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 162121e and b7ff242.
Files selected for processing (2)
  • docs/recipes/embed-catalog.mdx (1 hunks)
  • docs/recipes/import-existing-users.mdx (1 hunks)
Additional Context Used
LanguageTool (2)
docs/recipes/embed-catalog.mdx (1)

Near line 68: The phrase ‘have the ability to’ might be wordy. Consider using “can”.
Context: ...r own connectors insertvideo You have the ability to choose which connectors will be rendere...

docs/recipes/import-existing-users.mdx (1)

Near line 60: Possible missing comma found.
Context: ...sers You must know how to fetch linked users as you'll have to use them in the UI wi...

Comment on lines +66 to +68

You have the ability to choose which connectors will be rendered (also applied to magic-link).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the phrase for clarity.

- You have the ability to choose which connectors will be rendered
+ You can choose which connectors to render

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
**insert**video
You have the ability to choose which connectors will be rendered (also applied to magic-link).
**insert**video
You can choose which connectors to render (also applied to magic-link).

# How to fetch linked users

You must know how to fetch linked users as you'll have to use them in the UI widget prop.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comma for better readability.

- You must know how to fetch linked users as you'll have to use them in the UI widget prop.
+ You must know how to fetch linked users, as you'll have to use them in the UI widget prop.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
You must know how to fetch linked users as you'll have to use them in the UI widget prop.
You must know how to fetch linked users, as you'll have to use them in the UI widget prop.

@naelob naelob merged commit 1cf8964 into main May 23, 2024
14 of 18 checks passed
@naelob naelob deleted the feat/update-docs branch July 27, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants