Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared package import #380

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

mit-27
Copy link
Contributor

@mit-27 mit-27 commented Apr 19, 2024

Summary by CodeRabbit

  • Chore
    • Updated the development start script to include building a specific module before launching the application in watch mode.

Copy link

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: 2718b5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Apr 19, 2024

Walkthrough

The modification involves enhancing the start:dev script in the package.json of the api package to include a build step for a specific module before initiating the application in watch mode. This aims to resolve issues related to module imports in development environments.

Changes

File Path Change Summary
packages/api/package.json Modified start:dev to include a build step for a module before watch mode

Assessment against linked issues

Objective Addressed Explanation
Fix shared package import (#370) The change does not directly address the build failure of the shared package.
Resolve the issue with /api package not recognizing exports from shared-types package (#134) It's unclear if the change impacts the recognition of exports from shared-types.

Possibly related issues

🐇💻
A hop, a skip, a code deploy,
Build and watch, oh what a joy!
Through lines of code, we weave our spell,
Bugs retreat, as systems swell.
Celebrate, for we prevail! 🎉🥕


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 763d746 and 2718b5b.
Files selected for processing (1)
  • packages/api/package.json (1 hunks)
Additional comments not posted (1)
packages/api/package.json (1)

14-14: Ensure the start:dev script's new command is effective and does not introduce side effects.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@stytch/[email protected] None 0 137 kB jhaven-stytch
npm/@tanstack/[email protected] environment +1 3.58 MB tannerlinsley
npm/@tanstack/[email protected] None 0 103 kB tannerlinsley
npm/@tanstack/[email protected] environment +1 3.82 MB tannerlinsley
npm/@tanstack/[email protected] Transitive: environment +1 4.04 MB tannerlinsley
npm/@types/[email protected] None +11 120 kB types
npm/@types/[email protected] None +1 4.07 MB types
npm/@types/[email protected] None 0 33.9 kB types
npm/@types/[email protected] None +3 1.69 MB types
npm/[email protected] environment +68 70 MB peachscript
npm/[email protected] environment Transitive: filesystem, shell +10 2.72 MB ai
npm/[email protected] None +1 15.7 kB joebell93
npm/[email protected] None 0 8.46 kB lukeed
npm/[email protected] Transitive: environment +30 1.22 MB paco
npm/[email protected] network Transitive: environment, eval +3 65.3 kB dougwilson
npm/[email protected] None 0 4.86 MB kossnocorp
npm/[email protected] unsafe Transitive: environment, eval, filesystem, shell +206 19.5 MB vercel-release-bot
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +98 10.8 MB eslintbot
npm/[email protected] None 0 22.3 MB ericfennis
npm/[email protected] None 0 35.3 kB paco
npm/[email protected] environment, filesystem, network, shell, unsafe +22 1.11 GB vercel-release-bot
npm/[email protected] environment, filesystem +3 376 kB ai
npm/[email protected] None +2 8.39 MB timgl
npm/[email protected] environment 0 1.23 MB gpbl
npm/[email protected] environment +3 4.62 MB gnoff
npm/[email protected] network 0 898 kB bluebill1049
npm/[email protected] environment +2 337 kB gnoff
npm/[email protected] environment +39 11 MB ckifer
npm/[email protected] None 0 200 kB emilkowalski
npm/[email protected] None +2 989 kB dcas
npm/[email protected] None 0 18.1 kB thejameskyle
npm/[email protected] environment, filesystem Transitive: network, shell, unsafe +100 14 MB adamwathan
npm/[email protected] None 0 32.4 MB typescript-bot
npm/[email protected] None 0 628 kB colinmcd94
npm/[email protected] environment +1 365 kB daishi

🚮 Removed packages: npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@ntegral/[email protected], npm/@sentry/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Telemetry npm/[email protected]
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@naelob naelob merged commit 0ea781c into panoratech:main Apr 19, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix shared package import
2 participants