refactor: remove redundant edge case handling in Google Drive service…

…s (for changes api)
panoratech · Dec 24, 2024 · 11ee725 · 11ee725
1 parent e101198
commit 11ee725
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/packages/api/src/filestorage/file/services/googledrive/index.ts b/packages/api/src/filestorage/file/services/googledrive/index.ts
@@ -289,15 +289,6 @@ export class GoogleDriveService implements IFileService {
       pageToken = nextPageToken;
       newRemoteCursor = newStartPageToken || nextPageToken;
       apiCallCount++;
-
-      if (nextPageToken && changes.length === 0) {
-        // edge case where we have no changes but still have a nextPageToken
-        return {
-          filesToSync,
-          moreChangesToFetch: false,
-          remote_cursor: newRemoteCursor,
-        };
-      }
     } while (pageToken && apiCallCount < maxApiCalls);
 
     return {

diff --git a/packages/api/src/filestorage/folder/services/googledrive/index.ts b/packages/api/src/filestorage/folder/services/googledrive/index.ts
@@ -730,11 +730,6 @@ export class GoogleDriveFolderService implements IFolderService {
           'nextPageToken, newStartPageToken, changes(file(id,name,mimeType,createdTime,modifiedTime,size,parents,webViewLink,driveId,trashed,permissionIds))',
       });
 
-      if (!response.data.changes.length) {
-        // edge case where we have no changes but still have a nextPageToken
-        break;
-      }
-
       const batchFolders = response.data.changes
         .filter(
           (change) =>