Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SPDX license identifier #2808

Closed
wants to merge 1 commit into from
Closed

Use SPDX license identifier #2808

wants to merge 1 commit into from

Conversation

cdce8p
Copy link

@cdce8p cdce8p commented Nov 17, 2024

PEP 639 recommends the use of SPDX license identifiers.

At the moment the license key is ignored by flit, see pypa/flit#525. However, it's still possible to replace it now. Once the support in flit is added, the value will be used automatically.

At some point, the table will need be be changed to just a string for full PEP 639 compliance. That requires support for it first though. The change is also pretty simple.

-license = {text = "BSD-3-Clause"}
+license = "BSD-3-Clause"

--
Before the move to pyproject.toml, setup.cfg used BSD-3-Clause as well. https://github.com/pallets/click/blob/8.1.7/setup.cfg#L12

@cdce8p cdce8p marked this pull request as draft November 18, 2024 00:28
@Rowlando13
Copy link
Collaborator

Looks like license is a modified BSD-3 so I am not sure this is correct. @davidism thoughts?

@cdce8p
Copy link
Author

cdce8p commented Nov 18, 2024

Looks like license is a modified BSD-3 so I am not sure this is correct. @davidism thoughts?

Can you explain what specifically you mean? Github recognizes it correctly as the BSD-3-Clause license.
https://github.com/pallets/click/blob/main/LICENSE.txt
https://spdx.org/licenses/BSD-3-Clause.html

@davidism
Copy link
Member

It's not modified, should be standard BSD-3-Clause.

@davidism
Copy link
Member

I'm going to close this for now. Once Flit supports license = "string" and license_files = [...], you're welcome to create a PR for that.

@davidism davidism closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants