Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make traceback tests independent of numbers #634

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Make traceback tests independent of numbers #634

merged 1 commit into from
Sep 23, 2024

Conversation

singul4ri7y
Copy link
Contributor

Changelog:

  • Free traceback tests from relying on numbers which most-likely to change in the future, hence breaking.

Resolves #617

@singul4ri7y singul4ri7y requested a review from hugomg September 23, 2024 11:03
hugomg
hugomg approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@hugomg hugomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Maybe we could simplify the gsub to a single gsub for "%d+", but I assume you wanted to be more specific and only replace these instances right?

@singul4ri7y
Copy link
Contributor Author

@hugomg Yes. Because we have numbers in some test functions which also gets replaced unless we be specific.

@singul4ri7y singul4ri7y merged commit 56c41f9 into master Sep 23, 2024
2 checks passed
@singul4ri7y singul4ri7y deleted the fix-skip-frames branch September 23, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugomg hugomg hugomg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Skipped 379 frames" is too specific
2 participants
@singul4ri7y @hugomg