--emit-lua: Don't preserve comments inside type annotations #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm looking for ways to simplify the --emit-lua back end, and perhaps even move it to a separate tool instead of the Pallene compiler itself. The first step is to remove the feature of preserving comments inside type annotations that would be erased. It is not worth the complexity. 1. The lexer:next() used to return COMMENT tokens 2. The parser used to have to care about said COMMENT tokens 3. The comment_regions logic was subtle and needed many test cases.
hugomg
force-pushed
the
dont-preserve-comments
branch
from
faef803 to
12138fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking for ways to simplify the --emit-lua back end, and perhaps even move it to a separate tool instead of the Pallene compiler itself.
The first step is to remove the feature of preserving comments inside type annotations that would be erased. It is not worth the complexity.