Rms integration #52
Open
Rms integration #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojwanganto
commented
Nov 13, 2024
| @@ -129,6 +138,48 @@ public <E extends OpenmrsObject> E selectSingle(Class<E> cls, Serializable id) { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| @SuppressWarnings("unchecked") | |||
| public Set<Payment> getPaymentsByBillId(Integer billId) { | |||
There was a problem hiding this comment.
@PatrickWaweru - do we really need this? Can't we use bill.getPayment()?
ojwanganto
commented
Nov 13, 2024
| oldBill = (Bill) args[0]; | ||
|
|
||
| Integer oldBillId = oldBill.getId(); | ||
| oldPayments = Context.getService(IBillService.class).getPaymentsByBillId(oldBillId); |
There was a problem hiding this comment.
I introduced this here and removed the IbillService from the class variables
ojwanganto
commented
Nov 13, 2024
| http://www.springframework.org/schema/util | ||
| http://www.springframework.org/schema/util/spring-util-3.0.xsd"> | ||
|
|
||
|
|
||
| <bean id="billSavePaymentAspect" class="org.openmrs.module.kenyaemr.cashier.advice.NewBillPaymentSyncToRMS"/> |
There was a problem hiding this comment.
I removed the property from the class thus the drop here
ojwanganto
commented
Nov 13, 2024
| <bean id="billSavePaymentAspect" class="org.openmrs.module.kenyaemr.cashier.advice.NewBillPaymentSyncToRMS"/> | ||
|
|
||
| <!-- Create a proxy for BillService --> | ||
| <bean id="cashierBillService" class="org.springframework.aop.framework.ProxyFactoryBean"> |
There was a problem hiding this comment.
It is in these configurations where we potentially may have missed something. We will keep digging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PatrickWaweru - am putting this PR to help us jointly review the code. I know we can have it in the other module.