Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass checks against upcoming sf 1.0-18 #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pass checks against upcoming sf 1.0-18 #224

wants to merge 1 commit into from

Conversation

edzer
Copy link

@edzer edzer commented Oct 10, 2024

See r-spatial/sf#2441 (comment) ; upcoming sf will need this to pass checks.

paleolimbot
paleolimbot reviewed Oct 10, 2024
View reviewed changes
Copy link
Owner

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

It seems like wk should be adding the oriented = TRUE attribute to the outer sfc when converting rectangles to sfc?

@edzer
Copy link
Author

edzer commented Oct 10, 2024

Yes; in sf currently only st_as_sfc.bbox sets this always to TRUE.

@paleolimbot
Copy link
Owner

I'll open a PR shortly adding that here, too!

@edzer
Copy link
Author

edzer commented Oct 10, 2024

Are you OK if I let sf 1.0-18 go, thereby breaking wk on CRAN, or shall I wait?

@paleolimbot
Copy link
Owner

Go for it! I can fix + submit in the next day or so 🙂

@paleolimbot paleolimbot mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edzer @paleolimbot