Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows ARM build #220

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Fix windows ARM build #220

merged 3 commits into from
Jul 9, 2024

Conversation

paleolimbot
Copy link
Owner

From Tomas:

Dear Maintainer,

unfortunately your package cannot be built on Windows/aarch64, because it attempts to use a Microsoft intrinsic _umulh, which is not available with Rtools (non-Microsoft toolchain).

The fix is trivial, as attached, feel free to use the patch.

I am aware that your upstream version includes a different patch from Jeroen Ooms, claiming that it is a toolchain bug. That is not true, and my patch conditions on _MSC_VER, which I think is more correct.

But the difference is not critical, either way, please do submit a version that has a variant of the fix to CRAN. It would be great if you could do it, soon, as this is a trivial change but is needed for Windows/aarch64.

@paleolimbot paleolimbot merged commit ae11376 into master Jul 9, 2024
7 checks passed
@paleolimbot paleolimbot deleted the fix-win-arm-build branch July 9, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant