-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create AlarmCoordinator
to separate HA functions from the fetching logic
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
commented
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are required to improve the quality.
palazzem
commented
Oct 12, 2023
palazzem
force-pushed
the
palazzem/task-refactor-coordinator
branch
2 times, most recently
from
October 12, 2023 13:23
73b6ac1
to
14005af
Compare
palazzem
force-pushed
the
palazzem/task-refactor-coordinator
branch
from
October 12, 2023 13:23
14005af
to
932c893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
This change refactors entirely how the
DataUpdateCoordinator
is exposed to the integration. Instead of writing the fetching logic inside theasync_setup_entry
as a standalone function, we moved the entire logic in a dedicated class that is easy to test.AlarmCoordinator
is fully tested and a regression test is added to the test suite.Furthermore, the integration now uses
async_config_entry_first_refresh()
to call the first update, so that if there are issues with the update, the integration will raiseConfigEntryNotReady
exception, preventing the integration from loading. At that stage, the integration is flagged as "Failed to load", preventing logs spamming.Testing:
Extra Notes (optional):
n/a
Checklist