Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update econnect-python to 0.9.1 #116

Merged
merged 1 commit into from
Dec 6, 2023
Merged

deps: update econnect-python to 0.9.1 #116

merged 1 commit into from
Dec 6, 2023

Conversation

palazzem
Copy link
Owner

@palazzem palazzem commented Dec 6, 2023

Related Issues

Proposed Changes:

This update refines the query() method in the client, which fetches synchronized data between the main unit and the cloud (using _get_descriptions() under the hood). Issues arise when strings are not in sync, specifically when:

  1. The central unit has defined and InUse outputs, inputs, or sectors.
  2. The cloud is not in sync, leading to missing keys (9, 10, or 12) in _get_descriptions(), causing a KeyError.

To address this, we've implemented a safer access via the dictionary get() method. Now, if a string is missing, Unknown is returned instead of an error.

Testing:

Test with a central unit where an output is InUse, but no strings are configured in the cloud.

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem added this to the 2.2.1 milestone Dec 6, 2023
@palazzem palazzem self-assigned this Dec 6, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7115561947

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.095%

Totals Coverage Status
Change from base Build 7077754827: 0.0%
Covered Lines: 597
Relevant Lines: 629

💛 - Coveralls

@palazzem palazzem merged commit d06d911 into main Dec 6, 2023
5 checks passed
@palazzem palazzem deleted the palazzem/issue-115 branch December 6, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Configuration failed after update to 2.2
2 participants