feat: add query.OUTPUTS to collect outputs status #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
requested changes
Nov 9, 2023
There was a problem hiding this comment.
The change is good, but we need to add tests for it. Actually, we don't have tests that are verifying that the method actually returns outputs as it should. You need to add tests and fixtures like these:
- https://github.com/palazzem/econnect-python/blob/main/tests/test_client.py#L1326-L1423
- https://github.com/palazzem/econnect-python/blob/main/tests/fixtures/responses.py#L193-L242
- https://github.com/palazzem/econnect-python/blob/main/tests/conftest.py#L31
In general, for any change, you should:
- Update current tests so that they don't fail. In doing this, you must be sure you are not changing the behavior as if you are adding something, the rest of the software should work as before.
- Always add new tests. You must not reuse current tests to check new behavior as they were designed to test another behavior. In your case you added what happens if the
outputskey is missing (that is good), but it's not enough to be sure it works as expected. - Add a fixture where you actually put a static response to avoid real tests (
responses.py) - Update the
conftest.pywhere you actually add the response you generated in (3) to the call you expect inclientfixture.
After these changes, I think it should be all set! In the meantime, thank you very much for the help!
Pull Request Test Coverage Report for Build 6810659178
💛 - Coveralls |
palazzem
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add query.OUTPUTS to collect the status of the outputs in control panel
Testing:
Extra Notes (optional):
Checklist