Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add last_id for alerts poll #125

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

xtimmy86x
Copy link
Contributor

Related Issues

Proposed Changes:

With this change we add the support for verify the last id in the alerts for polling updates

Testing:

Extra Notes (optional):

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem changed the title feat: add last_id for alerts poll feat: add last_id for alerts poll Oct 24, 2023
@palazzem palazzem self-requested a review October 24, 2023 09:26
@palazzem palazzem added type:bug Something isn't working topic:client labels Oct 24, 2023
@palazzem palazzem added this to the 0.8.1 milestone Oct 24, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6619445658

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6587750601: 0.0%
Covered Lines: 349
Relevant Lines: 349

💛 - Coveralls

Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! I would say we should verify it in the HA integration, and then we can merge! No changes needed at the moment!

Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, QA testing works, so we're good to go!

@palazzem palazzem merged commit fa36cbe into palazzem:main Oct 24, 2023
3 checks passed
@xtimmy86x xtimmy86x deleted the xtimmy86x/alerts-pool-mod branch November 1, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:client type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants