Fix eslint errors #86

byrond · 2021-01-08T20:03:07Z

No description provided.

byrond · 2021-01-26T15:56:34Z

src/components/current-query/index.js

+FacetType.propTypes = {
+  id: PropTypes.string.isRequired,
+  onClick: PropTypes.string.isRequired,
+  children: PropTypes.node.isRequired,


I could probably remove isRequired and provide a default of [] instead. I think I did that in at least one other place.

byrond · 2021-01-26T17:17:48Z

src/components/current-query/index.js

+  return (searchField.value.map((val) => (
+    <FacetType
+      key={searchField.field}
+      id={searchField.field}


I did this to resolve a "don't use an index in the id" linting error. I don't think it changed/broke any behavior, but it's worth a look.

byrond · 2021-01-26T17:19:45Z

src/components/current-query/index.js

+                const MyFacetType = facetTypes[searchField.type];
+                return (
+                  <MyFacetType
+                    key={searchField.field}


Here's another instance of changing the key, so we don't use a loop index value.

byrond · 2021-01-26T17:23:07Z

src/components/federated-solr-faceted-search.js

-    const pagination = query.pageStrategy === 'paginate' ?
-      <PaginateComponent {...this.props} bootstrapCss={bootstrapCss} onChange={onPageChange} /> :
-      null;
+    /* eslint-disable react/jsx-props-no-spreading */


props contains a lot of properties, and I wasn't clear what they all are. I believe this is a valid case to disable the rule instead of explicitly listing all of them every time. We can revisit this later, though, if needed.

byrond · 2021-01-26T17:24:43Z

src/components/federated-solr-faceted-search.js

@@ -124,7 +133,7 @@ class FederatedSolrFacetedSearch extends React.Component {

                  return (
                    <SearchComponent
-                      key={i}
+                      key={searchField.field}


I changed the key here (like the others) and didn't notice any issues. Flagging this in case it is incorrect.

byrond · 2021-01-26T17:26:26Z

src/components/list-facet/index.js

      facetValues.forEach((v, i) => {
        const key = facetValues[i];
        facetInputs[key] = facetCounts[i];
      });
    }

-    const expanded = !(collapse || false);
+    const expanded = !collapse;
    const height = expanded ? 'auto' : 0;


Here's an example of a default value I moved to defaultProps.

byrond · 2021-01-26T17:28:28Z

src/components/list-facet/index.js

+        terms[type].items.forEach((termObj, j) => termObj.facetCount
+          && listFacetHierarchyTermsLis[type].push(
+            <li className="fs-search-accordion__content-item" key={`${termObj.term}_${termObj.facetValue}_${j}`}>
+              {/* eslint jsx-a11y/label-has-associated-control: ["error", { assert: "either" } ] */}


By default, the linting rule requires both nesting and id plus for attributes. However, it seemed like generating IDs at this level was discouraged, so I used an override to allow nesting the control under the label to be sufficient.

byrond · 2021-01-26T17:30:22Z

src/components/list-facet/index.js

@@ -178,31 +187,41 @@ class FederatedListFacet extends React.Component {
      const listFacetHierarchyLis = [];
      // Define array of checkbox Lis which we'll populate with react fragments, per type.
      const listFacetHierarchyTermsLis = [];
+
+      /* eslint-disable react/no-array-index-key */
+
      // Iterate through types (accordion lis).


I wasn't sure how to refactor this section to not use loop indexes in keys, so I temporarily disabled the rule. We may want to revisit this section later, so a TODO might be in order here.

byrond · 2021-01-26T17:30:53Z

src/components/list-facet/index.js

@@ -233,6 +257,7 @@ class FederatedListFacet extends React.Component {
    return (
      <li className="fs-search-accordion__group-item" id={`solr-list-facet-${field}`}>
        <div
+          role="button"


This is the default in most browsers.

byrond · 2021-01-26T17:33:11Z

src/components/results/pagination.js

-          <li className={cx("fs-search-pager__item fs-search-pager__item--first", {"fs-element-invisible": firstPageHidden})} key="start">
-            <button className={cx("fs-search-pager__item-button fs-search-pager__item-button--first")} tabIndex={firstPageHidden ? "-1" : "0"} onClick={this.onPageChange.bind(this, 0)} onKeyPress={ this.buildHandleEnterKeyPress(this.onPageChange.bind(this, 0)) } title="Go to first page">
+          <li className={cx('fs-search-pager__item fs-search-pager__item--first', { 'fs-element-invisible': firstPageHidden })} key="start">
+            <button type="submit" className={cx('fs-search-pager__item-button fs-search-pager__item-button--first')} tabIndex={firstPageHidden ? '-1' : '0'} onClick={this.onPageChange.bind(this, 0)} onKeyPress={this.buildHandleEnterKeyPress(this.onPageChange.bind(this, 0))} title="Go to first page">


Submit is the default type in most browsers.

byrond · 2021-01-26T17:34:47Z

src/components/search-field-container.js

 FederatedSearchFieldContainer.propTypes = {
-  children: PropTypes.array,
-  onNewSearch: PropTypes.func,
+  children: PropTypes.arrayOf(PropTypes.object),


I used PropTypes.node above, so I may need to change this. Also, I've used a default value here instead of isRequired. Whichever is correct, I'll make these consistent.

agentrickard · 2021-02-01T19:15:31Z

I started looking at this and still see a lot of console errors: e.g.

index.js:1 Warning: Failed prop type: Invalid prop `options.autocomplete` of type `object` supplied to `FederatedSolrFacetedSearch`, expected `boolean`.
    in FederatedSolrFacetedSearch (at src/index.js:153)

agentrickard · 2021-03-02T17:28:12Z

The remaining errors all seem to be PropType mismatches, where we are mixing booleans and objects. That needs to be cleaned up.

This reverts commit 78a6421.

fix eslint errors in curent-query component

69b42e7

byrond added the Work in-Progress Do not merge PR, currently being worked on. label Jan 8, 2021

byrond self-assigned this Jan 8, 2021

byrond added 15 commits January 8, 2021 15:23

code cleanup in current-query component

4ea5291

current-query: use field as key instead of index

69d27e5

fix eslint errors in federated-solr-faceted-search component

21194ad

fix eslint errors in FederatedSolrComponentPack

932f6f5

fix eslint errors in chevron icon

2299f74

fix eslint errors in search icon

16d5a75

fix eslint errors in FederatedListFacet component

3908a8a

fix eslint errors in FederatedRangeFacet component

f44d1e2

fix eslint errors in FederatedCountLabel component

08ecbd5

fix date picker in FederatedRangeFacet component

035495d

fix eslint errors in FederatedResultList component

c71d6d2

fix eslint errors in FederatedPagination component

dcf6d85

fix eslint errors in FederatedResult component

5d66075

fix result count text spacing

05e7b6e

fix eslint errors in FederatedSearchFieldContainer component

90cb22d

byrond commented Jan 26, 2021

View reviewed changes

fix eslint errors in FederatedSortMenu component

f5a0e74

byrond and others added 7 commits January 29, 2021 08:43

fix eslint errors in FederatedTextSearch component

9e96696

fix eslint errors in FederatedTextSearchNoAutocomplete component

8dc748f

fix eslint errors in FederatedTextSearchAsYouType component

b8bfc9f

fix eslint errors in helpers

b0fe669

fix eslint errors in index.js

87acaa0

fix autocomplete

9eab0b5

Fixes spacing of elements in autocomplete instructions.

50ebdfe

agentrickard added 3 commits March 2, 2021 11:09

Ignore anonymous functions in eslint.

0d5d167

Disable warnings for logging of console errors.

dd307ee

Remove dangerouslySetHtmlInner calls for straight vars.

78a6421

agentrickard added 7 commits March 2, 2021 13:44

Revert "Remove dangerouslySetHtmlInner calls for straight vars."

568ace0

This reverts commit 78a6421.

Restores innerHTML call and supresses the eslint error.

d02aa40

Resolve proptype mismatch.

e9fa70c

FIx siteList prop.

2ab7672

Fix bad autocomplete prop.

3c6add3

Fix prop type for query on search-as-you-type.

dff2e21

Cleans up array prop mismatches.

4932e28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix eslint errors #86

Fix eslint errors #86

byrond commented Jan 8, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

byrond Jan 26, 2021

agentrickard commented Feb 1, 2021

agentrickard commented Mar 2, 2021

Fix eslint errors #86

Are you sure you want to change the base?

Fix eslint errors #86

Conversation

byrond commented Jan 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agentrickard commented Feb 1, 2021

agentrickard commented Mar 2, 2021