Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3219157: Support Windows file paths #156

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mglaman
Copy link
Collaborator

@mglaman mglaman commented Jun 16, 2021

Would benefit from manual testing or an AppVeyor run on Windows.

NOTE Leaving as a Draft until manual review. Also, not sure if we should go down the Windows runner rabbithole – specifically with trying to configure the Composer VCS URL.

How to add this PR to your Drupal project:

cd /path/to/drupal/recommended-project
composer config repositories.1 vcs https://github.com/bluehorndigital/drupal-rector.git
composer require palantirnet/drupal-rector:dev-issue-3219157
cp vendor/palantirnet/drupal-rector/rector.php .
php vendor/bin/rector 

@mglaman mglaman marked this pull request as draft June 16, 2021 20:19
@bbrala
Copy link
Collaborator

bbrala commented Mar 8, 2024

This can be closed imo. Windows support is not something that's really relevant in my eyes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants