Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for s390x #337

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dilipgb
Copy link

@dilipgb dilipgb commented Mar 21, 2024

Summary

jam cli support for s390x architecture to build stacks in packeto community stack for s390x.

Use Cases

The stack build through jam cli will be used by knative functions in future to build function code through buildpacks.

Checklist

  • [yes] I have viewed, signed, and submitted the Contributor License Agreement.
  • [yes] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • [yes] I have added an integration test, if necessary.
  • [yes] I have reviewed the styleguide for guidance on my code quality.
  • [yes] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dilipgb dilipgb requested a review from a team as a code owner March 21, 2024 05:27
Copy link

linux-foundation-easycla bot commented Mar 21, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@dilipgb dilipgb marked this pull request as draft March 21, 2024 05:34
@dilipgb
Copy link
Author

dilipgb commented Mar 21, 2024

closes #338

@dilipgb dilipgb marked this pull request as ready for review March 25, 2024 08:29
@dilipgb
Copy link
Author

dilipgb commented Mar 25, 2024

@robdimsdale can you please help with reviewing the PR.

@sophiewigmore
Copy link
Member

Hey @dilipgb have you been able to test this and see that the jam binary works as expected on s390x?

@dilipgb
Copy link
Author

dilipgb commented Apr 1, 2024

@sophiewigmore there are some test case failures on s390x. I will mark it draft PR till I fix those issues. Thanks for taking a look at it.

@dilipgb dilipgb marked this pull request as draft April 1, 2024 05:50
@mhdawson
Copy link
Member

mhdawson commented Apr 4, 2024

@dilipgb great to see you working on this. Do you know if anybody has a similar plan to do the required addition for PPC?

@valen-mascarenhas14
Copy link

Hi @mhdawson . I'll be handling this task for PPC .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants