-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOPID-2575] Bump rn-keychain
and force AES_GCM_NO_AUTH
#6587
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-2575 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6587 +/- ##
==========================================
- Coverage 49.30% 49.30% -0.01%
==========================================
Files 1565 1565
Lines 32223 32224 +1
Branches 7288 7290 +2
==========================================
Hits 15887 15887
Misses 16298 16298
- Partials 38 39 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Short description
This PR updates the
react-native-keychain
library from version4.0.5
to9.2.2
, introducing more robustAES_GCM
encryption. This resolves an issue where session information would become corrupted ("whitened") on our test Pixel devices for users authenticated via EIC.The update impacts only Android users and is seamless for those already authenticated.
Fixes #6400
List of changes proposed in this pull request
react-native-keychain
library to version9.2.2
.Keychain.STORAGE_TYPE.AES_GCM_NO_AUTH
as the Android storage type.setPin
function to accommodate the modified return type ofsetGenericPasswordWithDefaultAccessibleOption
.Android Test
On Android devices, existing session information is retrieved from shared preferences using the previously selected encryption method. Upon the next save operation for session data, a new data store file is created with the updated
AES_GCM
encryption.iopid-kc-0107.mov
How to test
Prerequisites
Steps
react-native-keychain
library version4.0.5
and log in successfully using SPID.react-native-keychain
library version9.2.2
, then launch it. Verify that you remain logged in without being disconnected.