Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-1101] Add missing Mixpanel events/properties #6581

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

LeleDallas
Copy link
Contributor

Short description

This PR focus on enhancing the tracking of payment methods, receipt details, and user interactions adding missing events/properties to Mixpanel.

List of changes proposed in this pull request

  • Added trackPaymentWalletMethodDetail function to track details of payment methods
  • Updated handleOnMethodPress function to include tracking of payment method selection and status
  • Added organization_fiscal_code and payment_status to the trackPaymentsOpenReceipt function
  • trackPaymentsSaveAndShareReceipt to include additional receipt details
  • Added trackReceiptFilterUsage function to track the usage of receipt category filters
  • Added tracking for receipt filter usage in ReceiptListScreen
  • Updated ReceiptDetailsScreen and ReceiptPreviewScreen to include more comprehensive analytics tracking when downloading and sharing receipts

How to test

Verify with Proxyman that all data is being transmitted as specified in the open task description

@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Dec 24, 2024
@LeleDallas LeleDallas self-assigned this Dec 24, 2024
Copy link
Contributor

github-actions bot commented Dec 24, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-1101

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 49.29%. Comparing base (b207270) to head (2f3bb88).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/payments/receipts/analytics/index.ts 40.00% 3 Missing ⚠️
ts/features/payments/home/analytics/index.ts 33.33% 2 Missing ⚠️
...ts/home/components/PaymentsHomeUserMethodsList.tsx 50.00% 2 Missing ⚠️
...payments/receipts/screens/ReceiptPreviewScreen.tsx 0.00% 2 Missing ⚠️
...es/payments/receipts/screens/ReceiptListScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6581      +/-   ##
==========================================
- Coverage   49.30%   49.29%   -0.01%     
==========================================
  Files        1565     1565              
  Lines       32223    32235      +12     
  Branches     7288     7338      +50     
==========================================
+ Hits        15887    15890       +3     
+ Misses      16298    16295       -3     
- Partials       38       50      +12     
Files with missing lines Coverage Δ
.../features/payments/history/store/reducers/index.ts 51.11% <ø> (ø)
...payments/receipts/components/HideReceiptButton.tsx 5.88% <ø> (ø)
...payments/receipts/screens/ReceiptDetailsScreen.tsx 7.69% <ø> (ø)
...es/payments/receipts/screens/ReceiptListScreen.tsx 3.07% <0.00%> (-0.05%) ⬇️
ts/features/payments/home/analytics/index.ts 47.05% <33.33%> (-2.95%) ⬇️
...ts/home/components/PaymentsHomeUserMethodsList.tsx 80.76% <50.00%> (-2.91%) ⬇️
...payments/receipts/screens/ReceiptPreviewScreen.tsx 4.34% <0.00%> (-0.20%) ⬇️
ts/features/payments/receipts/analytics/index.ts 35.29% <40.00%> (-1.38%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8f237...2f3bb88. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant