-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIW-1455] Reissuing expired or expiring eID #6580
Open
RiccardoMolinari95
wants to merge
22
commits into
master
Choose a base branch
from
SIW-1455-credential-expiry-and-reissuing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[SIW-1455] Reissuing expired or expiring eID #6580
RiccardoMolinari95
wants to merge
22
commits into
master
from
SIW-1455-credential-expiry-and-reissuing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoMolinari95
requested review from
thisisjp,
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
December 24, 2024 09:54
RiccardoMolinari95
changed the title
[SIW-1455] eID re-issuing when jwt is expiring or expired
[SIW-1455] Reissuing Expired or Expiring eID
Dec 24, 2024
…-credential-expiry-and-reissuing
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1455 |
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
December 24, 2024 13:54 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR handle the reissuing of eID when it is expired or expiring and manages credential requests when the eID is expired, and the Wallet Instance is invalid
List of changes proposed in this pull request
ItwEidLifecycleAlert
to start eID reissuing, navigating toItwIdentificationModeSelectionScreen
with parameidReissuing
set totrue
eidReissuing
toItwIdentificationModeSelectionScreen
, if present send thestart-reissuing
event toitwEidIssuanceMachine
ItwPresentationEidVerificationExpiredScreen
, displayed when requesting a credential with the expired eID and a not valid Wallet InstanceItwPresentationEidVerificationExpiredScreen
inWalletCardOnboardingScreen
requesting a credential but the Wallet Instance is not validitwEidIssuanceMachine
created a new actionsetIsReissuing
to set theisReissuing
context state totrue
, and added a new guardisReissuing
to check if we are in the reissuing scenario.Added the
start-reissuing
event to theIdle
state, allowing a direct transition to theUserIdentification
state. Enhanced theUserIdentification
state to handle the back button differently based on whether the flow is in the reissuing scenario or not. Updated theDisplayingPreview
state to handle reissuing. IfisReissuing
istrue
, it navigates directly to the wallet; otherwise, it transitions to theSuccess
stateHow to test
To test the changes, simulate different scenarios by mocking the
jwt.expiration
of the stored eID credential: request the eID when it is expiring or expired, and attempt to request a credential with an expired eID and an invalid Wallet Instance, ensuring the correct screens and flows are triggeredRequesting credential with WI invalid and eID expired
Screen.Recording.2024-12-24.at.10.50.05.mov
Reissuing expiring eID (same flow for expired eID)
Screen.Recording.2024-12-24.at.10.38.58.mov