Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-1100] German FAQ strings #6579

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request corrects the display strings for the German FAQ.

List of changes proposed in this pull request

  • Update io-service-metadata version
  • Add german key to localeToLocalizedMessageKey constant
  • Added fallbackForLocalizedMessageKeys function to provide a fallback for German translations when they are not available
  • Updated locale handling to use the new fallback mechanism

How to test

Important

Align io-dev-api-server with this PR

  • Select German language, reload the app
  • Open the app
  • Tap on FAQ
  • Ensure that categories and subcategories are in german

Preview

Screen.Recording.2024-12-23.at.15.35.05.mov

@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Dec 23, 2024
@LeleDallas LeleDallas self-assigned this Dec 23, 2024
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-1100

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.30%. Comparing base (b207270) to head (e051814).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nce/screens/ItwIssuanceCredentialFailureScreen.tsx 0.00% 3 Missing ⚠️
...s/payments/home/components/PaymentsAlertStatus.tsx 0.00% 1 Missing ⚠️
ts/hooks/useStatusAlertProps.ts 50.00% 1 Missing ⚠️
ts/utils/payment.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6579   +/-   ##
=======================================
  Coverage   49.30%   49.30%           
=======================================
  Files        1565     1565           
  Lines       32223    32228    +5     
  Branches     7288     7290    +2     
=======================================
+ Hits        15887    15891    +4     
- Misses      16298    16299    +1     
  Partials       38       38           
Files with missing lines Coverage Δ
...heckout/components/WalletPaymentFeedbackBanner.tsx 64.28% <100.00%> (+2.74%) ⬆️
ts/i18n.ts 100.00% <ø> (ø)
ts/store/reducers/__mock__/backendStatus.ts 100.00% <ø> (ø)
ts/utils/locale.ts 81.48% <100.00%> (+1.48%) ⬆️
...s/payments/home/components/PaymentsAlertStatus.tsx 33.33% <0.00%> (ø)
ts/hooks/useStatusAlertProps.ts 60.00% <50.00%> (+2.85%) ⬆️
ts/utils/payment.ts 62.13% <0.00%> (ø)
...nce/screens/ItwIssuanceCredentialFailureScreen.tsx 9.09% <0.00%> (-0.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8f237...e051814. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support categories only uses italian strings
2 participants