-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1933] Handle Trustmark QR code generation failures #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
[SIW-1933] Handle Trustmark QR code generation failures
chore(IT Wallet): [SIW-1933] Handle Trustmark QR code generation failures
Dec 17, 2024
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1933 |
gispada
reviewed
Jan 8, 2025
gispada
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the handling of Trustmark generation failures in the Trustmark QR Code screen
List of changes proposed in this pull request
How to test
From the details screen of a credential, tap on the Trustmark button, check that everything works as expected.
Tip
You can make the Trustmark generation fail by mocking the
getCredentialTrustmarkActor
function and make it throwEnsure that when the Trustmark generation fails, the screens shows an error alert with a "Retry" button.
If you try to press the "Retry" button repeatedly, you should get an error toast telling you to wait a few seconds before trying to get the trustmark again.
Preview