Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1917] Fix crash in credentials onboarding screen #6544

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Dec 12, 2024

Short description

This PR fixes a crash in the credentials onboarding screen by adding a store migration needed after a store update made in #6516

List of changes proposed in this pull request

  • Added ITW store migration 1
  • Updated snapshot test with warning about this problem happening again

How to test

  1. Uninstall the app from your device
  2. Install it again building from a3799e3
  3. Activate the Wallet
  4. Navigate to the Credentials onboarding screen, check that everything works as expected
  5. Update the app building from this branch
  6. Navigate to the Credentials onboarding screen again, check that everything works as expected

@pagopa-github-bot pagopa-github-bot changed the title [SIW-1917] Fix crash in credentials onboarding screen fix(IT Wallet): [SIW-1917] Fix crash in credentials onboarding screen Dec 12, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 12, 2024

Affected stories

  • 🐞 SIW-1917: [io-app] Crash in schermata onboarding metodi e credenziali

Generated by 🚫 dangerJS against 19958e9

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.15%. Comparing base (4f204b4) to head (19958e9).
Report is 872 commits behind head on master.

Files with missing lines Patch % Lines
...s/features/itwallet/common/store/reducers/index.ts 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6544      +/-   ##
==========================================
+ Coverage   48.42%   49.15%   +0.72%     
==========================================
  Files        1488     1550      +62     
  Lines       31617    31973     +356     
  Branches     7669     7233     -436     
==========================================
+ Hits        15311    15716     +405     
+ Misses      16238    16218      -20     
+ Partials       68       39      -29     
Files with missing lines Coverage Δ
...s/features/itwallet/common/store/reducers/index.ts 71.42% <33.33%> (ø)

... and 1720 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9232798...19958e9. Read the comment docs.

@mastro993 mastro993 merged commit 5294897 into master Dec 12, 2024
12 checks passed
@mastro993 mastro993 deleted the SIW-1917-fix-crash-in-credentials-onboarding-screen branch December 12, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants