Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1902] Wallet accessibility improvements #6543

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented Dec 12, 2024

Short description

This PR fixes a small accessibility issue.

Note

The other accessibility issues mentioned in the Jira ticket must be addressed at the Design System level, in shared components. To speed up the fix, only issues that can be fixed in IO app are included here.

List of changes proposed in this pull request

  • Added proper accessibility label

How to test

Use a screen reader to navigate the wallet screen with an active wallet instance. The "Cos'è" label should not be announced as "undefined".

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 12, 2024

Affected stories

  • 🐞 SIW-1902: Bug di accessibilità della sezione portafoglio
    subtask of

Generated by 🚫 dangerJS against 7ac49a7

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.20%. Comparing base (4f204b4) to head (7ac49a7).
Report is 882 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6543      +/-   ##
==========================================
+ Coverage   48.42%   49.20%   +0.77%     
==========================================
  Files        1488     1556      +68     
  Lines       31617    32165     +548     
  Branches     7669     7280     -389     
==========================================
+ Hits        15311    15826     +515     
- Misses      16238    16300      +62     
+ Partials       68       39      -29     
Files with missing lines Coverage Δ
...eatures/wallet/components/WalletCardsContainer.tsx 100.00% <ø> (ø)

... and 1730 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a7134...7ac49a7. Read the comment docs.

@gispada gispada self-assigned this Dec 12, 2024
@gispada gispada marked this pull request as ready for review December 13, 2024 07:35
@gispada gispada requested review from ChrisMattew, freddi301 and a team as code owners December 13, 2024 07:35
@mastro993 mastro993 merged commit b4f9164 into master Dec 13, 2024
12 checks passed
@mastro993 mastro993 deleted the SIW-1902-wallet-accessibility-improvements branch December 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants