fix: [IOPID-2169] Fix toast messages behavior in the PrivacyMainScreen
#6526
Conversation
…ad data/remove account operations errors
pagopa-github-bot
changed the title
PrivacyMainScreenPrivacyMainScreen
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6526 +/- ##
==========================================
+ Coverage 48.42% 49.15% +0.72%
==========================================
Files 1488 1550 +62
Lines 31617 31972 +355
Branches 7669 7233 -436
==========================================
+ Hits 15311 15716 +405
+ Misses 16238 16217 -21
+ Partials 68 39 -29
... and 1720 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@mariateresaventura copy review needed! 🙏🏻 |
ChrisMattew
requested review from
thisisjp,
gispada,
freddi301 and
a team
as code owners
mariateresaventura
temporarily deployed
to
dev
GitHub Actions
Inactive
mariateresaventura
temporarily deployed
to
dev
GitHub Actions
Inactive
Done! |
…rectly call navigate
| if (pot.isError(userDataProcessing.DOWNLOAD)) { | ||
| // eslint-disable-next-line functional/immutable-data | ||
| canShowTooltipRef.current = true; | ||
| setRequestProcess(true); | ||
| dispatch( | ||
| loadUserDataProcessing.request( | ||
| UserDataProcessingChoiceEnum.DOWNLOAD | ||
| ) | ||
| ); | ||
| } else { | ||
| handleUserDataRequestAlert(UserDataProcessingChoiceEnum.DOWNLOAD); | ||
| } |
There was a problem hiding this comment.
What about wrapping this login inside a function having as parameter the UserDataProcessingChoiceEnum. What do you think?
There was a problem hiding this comment.
Thank you for the hint!
There was a problem hiding this comment.
Addressed here
Short description
This PR fixes the double toast message displayed when navigating to the
PrivacyMainScreenand retrieving information regarding the potential state of profile data download and/or account deletion is not possible. A single, less detailed toast message has been chosen instead of the previous two, which will be shown in case of an error in retrieving one or both pieces of information.List of changes proposed in this pull request
checkUpdatenow takes a list ofchoicesand manages the logic for displaying the toast message and both alerts internally.Demo
before-privacy-toast-message.mp4
after-privacy-toast-message.mp4
How to test
There are several ways to test this scenario. Personally, I tested it locally on the simulator by turning off the dev server or using a proxy tool (e.g., Proxyman) to manipulate the responses of the relevant requests before opening the screen. Simply put, on a physical device (or on a simulator in a production environment), you can replicate it by disabling the connection just before opening the screen. The choice is yours.