-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOPLT-787] Upgrade react-native-image-picker to fix android policy issue #6482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vangaorth
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on iOS simulator and on Fold4 Android 14
shadowsheep1
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on three different physical android devices (Motorola, Huawei, 1+)
LazyAfternoons
added a commit
that referenced
this pull request
Jan 9, 2025
…olicy issue (#6482) > [!note] > This PR depends on #6348 This PR upgrades `react-native-image-picker` to 7.2.2 in order to fix the new google play policy on the `READ_MEDIA_IMAGES` permission - Upgrade image picker library to latest available Check the pick of an image on Barcode screen on both OS to check everything's fine --------- Co-authored-by: LazyAfternoons <[email protected]> Co-authored-by: Damiano Plebani <[email protected]> Co-authored-by: LazyAfternoons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR depends on #6348
Short description
This PR upgrades
react-native-image-picker
to 7.2.2 in order to fix the new google play policy on theREAD_MEDIA_IMAGES
permissionList of changes proposed in this pull request
How to test
Check the pick of an image on Barcode screen on both OS to check everything's fine