Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-782] Add biz events receipt migration banner info #6188

Merged
merged 24 commits into from
Oct 17, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Sep 16, 2024

⚠️ This PR depends on #6187 ⚠️

Short description

This PR adds a banner inside the transaction details to inform the user if that transaction doesn't have the PDF available because it has been imported from the PM (the old payment gateway);

List of changes proposed in this pull request

  • Added a banner info inside the transaction details only if the origin of the transaction is PM (that means this transaction is imported);
  • Hide the Get the receipt button inside the transaction details if the origin is PM

How to test

With the dev server, try to edit the origin of a transaction setting the origin property to PM, you should be able to see the banner info and there must not be visible the CTA to download the receipt;

Preview

preview.mov

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 16, 2024

Affected stories

  • 🌟 IOBP-782: Inserire banner informativo per le transazioni importate dal PM
    subtask of
    • IOBP-540: Integrazione IO-BIZ Event/ricevute

Generated by 🚫 dangerJS against 67800dc

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.98%. Comparing base (4f204b4) to head (67800dc).
Report is 618 commits behind head on master.

Files with missing lines Patch % Lines
...eens/PaymentsTransactionBizEventsDetailsScreen.tsx 0.00% 3 Missing ⚠️
...onents/PaymentsBizEventsTransactionInfoSection.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6188      +/-   ##
==========================================
- Coverage   48.42%   46.98%   -1.44%     
==========================================
  Files        1488     1802     +314     
  Lines       31617    36546    +4929     
  Branches     7669     8649     +980     
==========================================
+ Hits        15311    17172    +1861     
- Misses      16238    19317    +3079     
+ Partials       68       57      -11     
Files with missing lines Coverage Δ
...onents/PaymentsBizEventsTransactionInfoSection.tsx 9.30% <0.00%> (ø)
...eens/PaymentsTransactionBizEventsDetailsScreen.tsx 9.09% <0.00%> (ø)

... and 1418 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a9b41...67800dc. Read the comment docs.

Copy link

dpulls bot commented Oct 17, 2024

🎉 All dependencies have been resolved !

…n-banner-info' into IOBP-782-add-biz-events-migration-banner-info
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong locale configuration for the English language

@Hantex9 Hantex9 merged commit 7fdb1dc into master Oct 17, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-782-add-biz-events-migration-banner-info branch October 17, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants